bpf: Support fentry/fexit for functions with union args #5902
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
Upstream branch: 9621eb6 |
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
bpf-next_base
branch
from
c979e9f to
2d215b0
Compare
Author
|
Upstream branch: e12873e |
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
series/999345=>bpf-next
branch
from
b8b1cff to
fda342c
Compare
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
bpf-next_base
branch
from
2d215b0 to
05282f4
Compare
Author
|
Upstream branch: 93a83d0 |
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
series/999345=>bpf-next
branch
from
fda342c to
9efc41f
Compare
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
bpf-next_base
branch
from
05282f4 to
e2bfc81
Compare
Author
|
Upstream branch: 60ef541 |
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
series/999345=>bpf-next
branch
from
9efc41f to
f3a953f
Compare
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
bpf-next_base
branch
from
e2bfc81 to
ba991b7
Compare
Author
|
Upstream branch: f859813 |
Currently, functions with 'union' arguments cannot be traced with
fentry/fexit:
bpftrace -e 'fentry:release_pages { exit(); }' -v
AST node count: 6
Attaching 1 probe...
ERROR: Error loading BPF program for fentry_vmlinux_release_pages_1.
Kernel error log:
The function release_pages arg0 type UNION is unsupported.
processed 0 insns (limit 1000000) max_states_per_insn 0 total_states 0 peak_states 0 mark_read 0
ERROR: Loading BPF object(s) failed.
The type of the 'release_pages' argument is defined as:
typedef union {
struct page **pages;
struct folio **folios;
struct encoded_page **encoded_pages;
} release_pages_arg __attribute__ ((__transparent_union__));
This patch relaxes the restriction by allowing function arguments of type
'union' to be traced.
Signed-off-by: Leon Hwang <[email protected]>
Adding verifier test for accessing union argument in tracing programs. The test program loads 1st argument of bpf_fentry_test11 function which is union and checks that verifier allows that. cd tools/testing/selftests/bpf ./test_progs -t verifier_btf_ctx 501/7 verifier_btf_ctx_access/btf_ctx_access union arg accept:OK 501 verifier_btf_ctx_access:OK Summary: 1/7 PASSED, 0 SKIPPED, 0 FAILED Signed-off-by: Leon Hwang <[email protected]>
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
series/999345=>bpf-next
branch
from
f3a953f to
1e15f4f
Compare
Author
|
At least one diff in series https://patchwork.kernel.org/project/netdevbpf/list/?series=999345 expired. Closing PR. |
kernel-patches-daemon-bpf-rc
bot
deleted the
series/999345=>bpf-next
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request for series with
subject: bpf: Support fentry/fexit for functions with union args
version: 1
url: https://patchwork.kernel.org/project/netdevbpf/list/?series=999345